docs(dip31): platform proof of service #157
Open
+122
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
requested review from
shumkov,
ogabrielides,
knst,
lklimek,
UdjinM6,
HashEngineering,
PastaPastaPasta and
QuantumExplorer
ogabrielides
requested changes
Oct 3, 2024
shumkov
requested changes
Oct 19, 2024
|
|
||
| ## Abstract | ||
|
|
||
| Core will introduce a new P2P message `platformban`, which, when properly signed and received by a |
There was a problem hiding this comment.
For better understanding, I would say that platform is triggering this process
dip-0031.md
Outdated
| 1. Check if the node is synced | ||
| * Penalty: skip validation of message, do not forward, do not mark as received in inventory | ||
| 2. Validate the protxHash is in the masternodeList | ||
| * Penalty: small P2P penalty (1), as the masternode may have very recently been removed |
There was a problem hiding this comment.
We should use the term evonode everywhere instead of masternode and do not mix both terms.
| * Penalty: small P2P penalty (1), as the masternode may have very recently been removed | ||
| 3. Validate the masternode associated with the protxHash is an evonode and not a regular masternode | ||
| * Penalty: Ban node, P2P penalty (100) | ||
| 4. Validate the signedHeight is valid and not too far in the past or future |
There was a problem hiding this comment.
@PastaPastaPasta can you add a suggestion to clarify this one?
| Once validation succeeds, Core shall adjust an internal `PlatformPoSeBan` flag from `false` to | ||
| `true`. This flag should be stored on disk and persisted across restarts. | ||
|
|
||
| ## Effect |
There was a problem hiding this comment.
Shall we describe how ProUpServTx affects PlatformPoSeBanned?
There was a problem hiding this comment.
Isn't that what the last sentence of the paragraph does?
The flag
PlatformPoSeBannedmust be set to false when an evonode is revived in the deterministic masternode list (DML).
thephez
force-pushed
the
dip-platform-pose
branch
from
42511dc
to
87fe980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that evonodes provide service on Dash Platform and that non-functioning evonodes do not participate in the Platform validator set, Platform needs a way to exclude faulty evonodes from future Platform validator sets / quorums. Since these nodes are not properly providing service, they should be proof-of-service (PoSe) banned. This DIP outlines a method for Platform to securely notify Core that a node should be banned.