Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: other core 21 updates #257

Merged
merged 31 commits into from
Aug 2, 2024
Merged

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Jul 6, 2024

Issue being fixed or feature implemented

  • some refactoring
  • some simplification
  • some bug fixes for when syncing gets stuck at 31%
  • Some enhanced logging on locks

What was done?

How Has This Been Tested?

QA using the Dash Wallet app

Breaking Changes

Some deprecated functions were removed.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@HashEngineering HashEngineering self-assigned this Jul 6, 2024
* use auto close on a stream

Signed-off-by: HashEngineering <[email protected]>
* add hashCode

Signed-off-by: HashEngineering <[email protected]>
…dMasternodeListManager

Signed-off-by: HashEngineering <[email protected]>
…fiedMasternodeListDiff

Signed-off-by: HashEngineering <[email protected]>
Comment on lines -408 to +416
log.info("message = {}", lastRequest.getRequestMessage().toString(blockChain));
// This was causing a dead lock when using toString(DualBlockchain). Use toString() instead.
log.info("message = {}", lastRequest.getRequestMessage());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the stuck at 30-31%, a log.info call.

The lastRequest.getRequestMessage().toString(blockChain) was taking a long time searching through blockChain to find the block header to link a block hash to a height.

Now, we won't get the heights by calling the default toString().

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 49.13495% with 147 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-core-21@9840285). Learn more about missing BASE report.

Files Patch % Lines
.../main/java/org/bitcoinj/evolution/QuorumState.java 12.50% 26 Missing and 2 partials ⚠️
...g/bitcoinj/evolution/SimplifiedMasternodeList.java 54.16% 16 Missing and 6 partials ⚠️
...va/org/bitcoinj/evolution/QuorumRotationState.java 75.29% 12 Missing and 9 partials ⚠️
...ava/org/bitcoinj/quorums/SimplifiedQuorumList.java 40.74% 12 Missing and 4 partials ⚠️
.../java/org/bitcoinj/quorums/InstantSendManager.java 21.42% 11 Missing ⚠️
...ain/java/org/bitcoinj/quorums/FinalCommitment.java 0.00% 10 Missing ⚠️
...ain/java/org/bitcoinj/crypto/BLSLazySignature.java 18.18% 8 Missing and 1 partial ⚠️
...itcoinj/evolution/DeterministicMasternodeList.java 0.00% 5 Missing ⚠️
...java/org/bitcoinj/governance/GovernanceObject.java 0.00% 5 Missing ⚠️
...n/java/org/bitcoinj/quorums/ChainLocksHandler.java 0.00% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@                Coverage Diff                 @@
##             feature-core-21     #257   +/-   ##
==================================================
  Coverage                   ?   51.24%           
  Complexity                 ?     6613           
==================================================
  Files                      ?      405           
  Lines                      ?    38659           
  Branches                   ?     6015           
==================================================
  Hits                       ?    19810           
  Misses                     ?    16611           
  Partials                   ?     2238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HashEngineering HashEngineering merged commit cde88a3 into feature-core-21 Aug 2, 2024
4 checks passed
@HashEngineering HashEngineering deleted the feat-core-21-updates branch August 13, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant