feat: bls improvements and other fixes #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HashEngineering <[email protected]>
…ation Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
HashEngineering
force-pushed
the
feature-bls-improvements
branch
from
40606a7
to
03407a7
Compare
HashEngineering
changed the title
HashEngineering
commented
May 4, 2024
Comment on lines
+764
to
+772
| if (version != MIN_STANDARD_VERSION) { | ||
| if (getVersionShort() == SPECIAL_VERSION) { | ||
| s.append(indent).append("version: ").append(getVersionShort()).append('\n'); | ||
| Type type = (getVersionShort() == SPECIAL_VERSION) ? getType() : Type.TRANSACTION_NORMAL; | ||
| s.append(" type: ").append(type.toString()).append('(').append(type.getValue()).append(")\n"); | ||
| } else { | ||
| s.append(indent).append("version: ").append(version).append('\n'); | ||
| } | ||
| } |
There was a problem hiding this comment.
a cleaner way to print the version for a transaction
HashEngineering
commented
May 21, 2024
Comment on lines
714
to
728
| peer.sendMessage(lastRequest.getRequestMessage()); | ||
|
|
||
| if (retryFuture != null) { | ||
| log.info("sendMessageFuture cancel: {}", lastRequest.request.getClass().getSimpleName()); | ||
| retryFuture.cancel(true); | ||
| retryFuture = null; | ||
| } | ||
| retryFuture = scheduledExecutorService.schedule(() -> { | ||
| if (!lastRequest.getReceived()) { | ||
| log.info("sendMessageFuture check: last request not received {}", lastRequest.request.getClass().getSimpleName()); | ||
| retryLastRequest(peer, new TimeoutException("last request not received")); | ||
| } else { | ||
| log.info("sendMessageFuture check: last request received {}", lastRequest.request.getClass().getSimpleName()); | ||
| } | ||
| }, 10, TimeUnit.SECONDS); |
There was a problem hiding this comment.
This is the new means of retry instead of using a ListenableFuture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only