-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(core): add tests for Ed25519 Evolution Node key derivation #221
Conversation
Signed-off-by: HashEngineering <[email protected]>
IDeterministicKey first = masterKey.deriveChildKey(ChildNumber.NINE_HARDENED); | ||
IDeterministicKey second = first.deriveChildKey(ChildNumber.FIVE_HARDENED); | ||
IDeterministicKey third = second.deriveChildKey(new ChildNumber(3, true)); | ||
IDeterministicKey fourth = third.deriveChildKey(new ChildNumber(4, true)); | ||
IDeterministicKey fifth = fourth.deriveChildKey(new ChildNumber(0, true)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here derivation is done manually.
IDeterministicKey votingKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_VOTING).getKey(0); | ||
IDeterministicKey ownerKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_OWNER).getKey(0); | ||
IDeterministicKey operatorKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_OPERATOR).getKey(0); | ||
IDeterministicKey platformKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_PLATFORM_OPERATOR).getKey(0, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, the key derivation is handled by the AuthenticationGroupExtension
object.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
============================================
+ Coverage 46.88% 47.05% +0.16%
- Complexity 6431 6467 +36
============================================
Files 408 408
Lines 45882 45906 +24
Branches 6482 6485 +3
============================================
+ Hits 21512 21599 +87
+ Misses 21988 21930 -58
+ Partials 2382 2377 -5
☔ View full report in Codecov by Sentry. |
…icationGroupExtension Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only