tests(core): add tests for Ed25519 Evolution Node key derivation #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HashEngineering <[email protected]>
HashEngineering
commented
Jul 17, 2023
Comment on lines
+127
to
+131
| IDeterministicKey first = masterKey.deriveChildKey(ChildNumber.NINE_HARDENED); | ||
| IDeterministicKey second = first.deriveChildKey(ChildNumber.FIVE_HARDENED); | ||
| IDeterministicKey third = second.deriveChildKey(new ChildNumber(3, true)); | ||
| IDeterministicKey fourth = third.deriveChildKey(new ChildNumber(4, true)); | ||
| IDeterministicKey fifth = fourth.deriveChildKey(new ChildNumber(0, true)); |
There was a problem hiding this comment.
Here derivation is done manually.
HashEngineering
commented
Jul 17, 2023
| IDeterministicKey votingKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_VOTING).getKey(0); | ||
| IDeterministicKey ownerKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_OWNER).getKey(0); | ||
| IDeterministicKey operatorKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_OPERATOR).getKey(0); | ||
| IDeterministicKey platformKey = mnext.getKeyChain(AuthenticationKeyChain.KeyChainType.MASTERNODE_PLATFORM_OPERATOR).getKey(0, true); |
There was a problem hiding this comment.
Here, the key derivation is handled by the AuthenticationGroupExtension object.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
============================================
+ Coverage 46.88% 47.05% +0.16%
- Complexity 6431 6467 +36
============================================
Files 408 408
Lines 45882 45906 +24
Branches 6482 6485 +3
============================================
+ Hits 21512 21599 +87
+ Misses 21988 21930 -58
+ Partials 2382 2377 -5
☔ View full report in Codecov by Sentry. |
…icationGroupExtension Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Signed-off-by: HashEngineering <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only