Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple fixes to conditions we check while opening new connections #6538

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 23, 2025

Issue being fixed or feature implemented

Changes:

What was done?

See above/individual commits

How Has This Been Tested?

  • Run tests
  • Run testnet/mainnet masternode for a day or two

Breaking Changes

It's now possible to have regular nodes with the same address but different ports on mainnet too but that's not a breaking change hopefully.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

We backported 15486 incorrectly...
…ions

Dropped conditions:
- do not check masternode ports in `ThreadOpenConnections`, it's done on consensus level on DMN registration/updates
- do not check connections on IP-only basis, masternodes handle duplicate mn connections via mnauth, regular nodes don't need that at all
…hile `loop

Allows non-specific conditions to trigger first for better compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant