fix: multiple fixes to conditions we check while opening new connections #6538
+20
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Changes:
fAllowMultiplePorts
was introduced in Switch CNetFulfilledRequestManager and CMasternodeMan maps/funcs to CService #1967 to preserve the behaviour of the old non-deterministic masternode list while fixingnetfulfilledman
. Most of that code is gone because we use DMN now andfAllowMultiplePorts
is kind of useless (and even confusing). Should be safe to drop it completely imo. Inspired by 6451dd7 in feat(net): add "system ports" and Bitcoin ports to "bad" ports list #6535.addr
belongs to the set of already connected masternodes, should simply continue just like we do when we findaddr
from the same net groupWhat was done?
See above/individual commits
How Has This Been Tested?
Breaking Changes
It's now possible to have regular nodes with the same address but different ports on mainnet too but that's not a breaking change hopefully.
Checklist: