Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement the dash analogue to BIP143 #5860

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat: implement the dash analogue to BIP143 #5860

wants to merge 16 commits into from

Commits on Feb 22, 2024

  1. feat: add dip143 sigversion

    @panleone
    panleone committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    cb97745 View commit details
    Browse the repository at this point in the history

  2. feat: add SIGHASH_DIP0143

    @panleone
    panleone committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8ba0483 View commit details
    Browse the repository at this point in the history

  3. refactor: return directly the double sha256 when needed

    @panleone
    panleone committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    437ef2f View commit details
    Browse the repository at this point in the history

  4. feat: implement dip143 transaction sighash

    @panleone
    panleone committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7d33c86 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. feat: add SCRIPT_ENABLE_DIP0143 

    Only if this flag is enabled it's possible to use the new sighash algorithm
    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    67457dd View commit details
    Browse the repository at this point in the history

  2. refactor: remove SigVersion from EvalScript 

    Since Sigversion is now a local property of each input.
    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    abad7f4 View commit details
    Browse the repository at this point in the history

  3. feat: add DIP0143 regtest params

    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    1c313a9 View commit details
    Browse the repository at this point in the history

  4. feat: Use DIP0143 flag only when the corresponding EHF is active

    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    dd401ec View commit details
    Browse the repository at this point in the history

  5. test: unit test coverage for the function SignatureHash

    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    fe464fb View commit details
    Browse the repository at this point in the history

  6. test: VerifyScript unit test coverage 

    - Test that txs with SigVersion DIP0143 pass script verification only when the corresponding flag is set
- Test that multi sig transactions can have their inputs signed with different SigVersion (one BASE, the other DIP0143)
- Test that SigHashType DIP0143 cannot be used alone
    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    fc6fc90 View commit details
    Browse the repository at this point in the history

  7. test: add DIP0143SignatureHash 

    So it is possible to generate DIP0143 SigHash from python tests
    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    038adfa View commit details
    Browse the repository at this point in the history

  8. test: add dip0143 functional test

    @panleone
    panleone committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    5474e72 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. test: extend sighash_tests/sighash_test to check SigVersion::DIP0143 too

    @UdjinM6 @panleone
    UdjinM6 authored and panleone committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0e0675c View commit details
    Browse the repository at this point in the history

  2. fix: adjust TestSigHashFromData to read amounts correctly

    @UdjinM6 @panleone
    UdjinM6 authored and panleone committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3f3c81d View commit details
    Browse the repository at this point in the history

  3. test: Include a random vExtraPayload in RandomTransaction

    @panleone
    panleone committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    00d60b9 View commit details
    Browse the repository at this point in the history

  4. [squash] test: regenerate sighash_dip0143 tests

    @panleone
    panleone committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0a2b5c8 View commit details
    Browse the repository at this point in the history