build: Disable miner for Windows binaries built via Guix #5801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not convinced this will solve anything; but I've started a windows guix build; can share binaries later |
|
See below for windows installer and detached gpg signature |
PastaPastaPasta
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Okay; wow. I think strong ACK comparing virustotal on this branch unsigned this branch signed and 20.0.3
knst
approved these changes
Jan 6, 2024
knst
pushed a commit
to knst/dash
that referenced
this pull request
Jan 10, 2024
## Issue being fixed or feature implemented We had this in Gitian https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-win.yml#L38. We also had it for macos https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-osx.yml#L42 but it looks like it's no longer an issue there (or at least I did not see anyone complaining about it). ## What was done? tweak `CONFIGFLAGS` for `mingw` host ## How Has This Been Tested? n/a ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We had this in Gitian https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-win.yml#L38. We also had it for macos https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-osx.yml#L42 but it looks like it's no longer an issue there (or at least I did not see anyone complaining about it).
What was done?
tweak
CONFIGFLAGSformingwhostHow Has This Been Tested?
n/a
Breaking Changes
n/a
Checklist: