Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Disable miner for Windows binaries built via Guix #5801

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 6, 2024

Issue being fixed or feature implemented

We had this in Gitian https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-win.yml#L38. We also had it for macos https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-osx.yml#L42 but it looks like it's no longer an issue there (or at least I did not see anyone complaining about it).

What was done?

tweak CONFIGFLAGS for mingw host

How Has This Been Tested?

n/a

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20.1 milestone Jan 6, 2024
@PastaPastaPasta
Copy link
Member

I'm not convinced this will solve anything; but I've started a windows guix build; can share binaries later

@PastaPastaPasta
Copy link
Member

See below for windows installer and detached gpg signature
Unsigned Installer
Detached GPG Sig

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay; wow. I think strong ACK comparing virustotal on this branch unsigned this branch signed and 20.0.3

Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

that's quite bad workaround IMO but that's much better than false-positive alert from antivirus.

@PastaPastaPasta PastaPastaPasta merged commit 52f0411 into dashpay:develop Jan 9, 2024
11 checks passed
knst pushed a commit to knst/dash that referenced this pull request Jan 10, 2024
## Issue being fixed or feature implemented
We had this in Gitian
https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-win.yml#L38.
We also had it for macos
https://github.com/dashpay/dash/blob/master/contrib/gitian-descriptors/gitian-osx.yml#L42
but it looks like it's no longer an issue there (or at least I did not
see anyone complaining about it).

## What was done?
tweak `CONFIGFLAGS` for `mingw` host

## How Has This Been Tested?
n/a

## Breaking Changes
n/a

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
@UdjinM6 UdjinM6 modified the milestones: 20.1, 20.0.4 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants