Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update builder keys for pasta, udjin #5797

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Jan 2, 2024

Issue being fixed or feature implemented

Builder keys in repo of @UdjinM6 @PastaPastaPasta are expired:

pub   rsa4096 2015-04-07 [SC] [expired: 2019-04-07]
      3F5D48C9F00293CD365A3A9883592BD1400D58D9
uid           [ expired] UdjinM6 <[email protected]>

pub   rsa4096 2019-08-14 [SC] [expired: 2021-08-14]
      29590362EC878A81FD3C202B52527BEDABE87984
uid           [ expired] Pasta <[email protected]>

What was done?

Imported new keys from keybase.io/pasta
Called gpg --refresh-keys for udjin

How Has This Been Tested?

$ gpg --list-keys
pub   rsa4096 2015-04-07 [SC] [expires: 2030-12-31]
      3F5D48C9F00293CD365A3A9883592BD1400D58D9
uid           [ unknown] UdjinM6 <[email protected]>
uid           [ unknown] UdjinM6 <[email protected]>
uid           [ unknown] UdjinM6 <[email protected]>
sub   rsa4096 2015-04-07 [E] [expires: 2025-01-15]

pub   rsa4096 2019-08-14 [SC] [expires: 2026-08-16]
      29590362EC878A81FD3C202B52527BEDABE87984
uid           [ unknown] Pasta <[email protected]>
sub   rsa4096 2019-08-14 [E] [expires: 2026-08-16]

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

It needs to update guix.sigs repo also: https://github.com/dashpay/guix.sigs

@knst knst added this to the 20.0.3 milestone Jan 2, 2024
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK; validated the gpg keys are the same via

curl https://raw.githubusercontent.com/dashpay/dash/f783e1d82b1dad3b412cc38ccac78912532c815f/contrib/builder-keys/pasta.pgp | gpg
curl https://raw.githubusercontent.com/dashpay/dash/f783e1d82b1dad3b412cc38ccac78912532c815f/contrib/builder-keys/udjinm6.pgp | gpg
curl https://raw.githubusercontent.com/dashpay/dash/develop/contrib/builder-keys/pasta.pgp | gpg
curl https://raw.githubusercontent.com/dashpay/dash/develop/contrib/builder-keys/udjinm6.pgp | gpg

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 9ef39aa into dashpay:develop Jan 7, 2024
5 of 6 checks passed
knst pushed a commit to knst/dash that referenced this pull request Jan 10, 2024
chore: update builder keys for pasta, udjin
knst pushed a commit to knst/dash that referenced this pull request Jan 10, 2024
chore: update builder keys for pasta, udjin
@UdjinM6 UdjinM6 modified the milestones: 20.0.3, 20.0.4 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants