fix(dashpay): username request voting period bugs #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
approved these changes
Oct 30, 2024
| @@ -247,7 +253,7 @@ class RequestUserNameViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| fun checkUsername(requestedUserName: String?) { | |||
| viewModelScope.launch { | |||
| viewModelScope.launch(Dispatchers.IO) { | |||
There was a problem hiding this comment.
In general, it's better not to dispatch coroutines in IO scope at the top level, but go down to where the actual work is done and call it inside withContext(Dispatchers.IO) so that the top-level callers don't have to worry about threading, correct context and switching back to the main thread to update UI.
There was a problem hiding this comment.
thanks for this idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: