feat(dashpay): add mix dash first warning dialog #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
approved these changes
Sep 29, 2024
| startActivity(Intent(requireContext(), CreateUsernameActivity::class.java)) | ||
| lifecycleScope.launch { | ||
| val shouldShowMixDashDialog = withContext(Dispatchers.IO) { createIdentityViewModel.shouldShowMixDash() } | ||
| //withContext(Dispatchers.Main) { |
There was a problem hiding this comment.
I guess this is commented because it wasn't clear if needed or not. lifecycleScope will execute in the main thread and shouldShowMixDash() is dispatched in IO with the result being returned back to the main thread, so Dispatchers.Main context indeed isn't needed.
viewModelScope by default also runs in the main thread.
There was a problem hiding this comment.
I will remove the withContext(Dispatchers.Main) comment
… into dashpay-feature-mix-dash-first
HashEngineering
changed the base branch from
dashpay-username-voting
to
dashpay-voting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: