Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashpay): add mix dash first warning dialog #1309

Merged
merged 23 commits into from
Sep 30, 2024

Conversation

HashEngineering
Copy link
Collaborator

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

startActivity(Intent(requireContext(), CreateUsernameActivity::class.java))
lifecycleScope.launch {
val shouldShowMixDashDialog = withContext(Dispatchers.IO) { createIdentityViewModel.shouldShowMixDash() }
//withContext(Dispatchers.Main) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is commented because it wasn't clear if needed or not. lifecycleScope will execute in the main thread and shouldShowMixDash() is dispatched in IO with the result being returned back to the main thread, so Dispatchers.Main context indeed isn't needed.

viewModelScope by default also runs in the main thread.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the withContext(Dispatchers.Main) comment

@HashEngineering HashEngineering changed the base branch from dashpay-username-voting to dashpay-voting September 30, 2024 16:01
@HashEngineering HashEngineering merged commit 5875a86 into dashpay-voting Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants