Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashpay feature submit request backend #1301

Merged
merged 37 commits into from
Aug 29, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Aug 28, 2024

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Aug 28, 2024
@HashEngineering HashEngineering marked this pull request as ready for review August 28, 2024 18:45
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Licenses might need fixes, some are wrong and others seem missing

* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we using MIT in the wallet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPL3, but some how there are some Apache 2.0 licenses in the headers

@HashEngineering HashEngineering merged commit 71d1092 into dashpay Aug 29, 2024
1 check passed
@HashEngineering HashEngineering deleted the dashpay-feature-submit-request-backend branch October 8, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants