feat: warn user of stale exchange rates #1284
Conversation
| class ExchangeRatesConfig | ||
| @Inject | ||
| constructor( | ||
| context: Context, | ||
| walletDataProvider: WalletDataProvider | ||
| ) : BaseConfig( | ||
| context, | ||
| PREFERENCES_NAME, | ||
| walletDataProvider | ||
| ) { | ||
| companion object { | ||
| private const val PREFERENCES_NAME = "exchange_rates_config" | ||
| val EXCHANGE_RATES_RETRIEVAL_TIME = longPreferencesKey("exchange_rates_retrieval_time") | ||
| val EXCHANGE_RATES_RETRIEVAL_FAILURE = booleanPreferencesKey("exchange_rates_retrieval_error") | ||
| val EXCHANGE_RATES_PREVIOUS_RETRIEVAL_TIME = longPreferencesKey("exchange_rates_previous_retrieval_time") | ||
| } | ||
| } |
There was a problem hiding this comment.
At first I was going to put these in WalletUIConfig, but that would have created a circular reference.
There was a problem hiding this comment.
WalletUIConfig might be better to leave for UI settings that can be changed by the user, or closely related preferences.
| constructor(currencyCode: String, rate: String?, retrievalTime: Long) { | ||
| this.currencyCode = currencyCode | ||
| this.rate = rate | ||
| this.retrievalTime = retrievalTime |
There was a problem hiding this comment.
CTX does return a field that contains the time their servers last retrieved this particular rate.
It is possible for CTX to return rates, but they are stale.
| currencyName = | ||
| if (currencyCode.length == 3) { | ||
| try { | ||
| getCurrency().displayName | ||
| } catch (x: IllegalArgumentException) { | ||
| currencyCode | ||
| } | ||
| } else { | ||
| currencyCode | ||
| } |
There was a problem hiding this comment.
Here, I am sure that the ktlint plugin on automatically formatted this file upon save. I have turned off this feature.
| object MyTheme { | ||
| val ToastBackground = Color(0xff191c1f).copy(alpha = 0.9f) | ||
|
|
||
| val Body2Regular = TextStyle( | ||
| fontSize = 14.sp, | ||
| lineHeight = 20.sp, | ||
| fontFamily = FontFamily.Default, // FontFamily(Font(R.font.inter)) // crashes, | ||
| fontWeight = FontWeight(400), | ||
| color = Color.White | ||
| ) |
There was a problem hiding this comment.
This is a start for a "stylesheet" file. There probably is a better way to do this, perhaps a standard way that it is done with Compose.
There was a problem hiding this comment.
Usually in JC you would set a MaterialTheme with a typography field, however, the names of standard text styles aren't going to match with our typography sheet in Figma, so it's better to have named styles as you did here.
| previousRates.clear() | ||
| previousRates.addAll(exchangeRatesDao.getAll()) |
There was a problem hiding this comment.
here we save the previous rates in memory to compare with the new rates.
| val storageManagerIntent = | ||
| Intent( | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| StorageManager.ACTION_MANAGE_STORAGE | ||
| } else { | ||
| Settings.ACTION_MANAGE_APPLICATIONS_SETTINGS | ||
| } | ||
| ) |
There was a problem hiding this comment.
Is there a way to get the ktlint plugin for Android Studio to use our rules in this project?
This was another case where I was using the new ktlint plugin to reformat a file on save, which would actually change a lot in wallet and in other modules may apply rules that we don't use.
There was a problem hiding this comment.
I think if you set .editorconfig as the baseline file in ktlint plugin settings, it should pickup our rules.
I removed ktlint plugin from the studio because after some update it broke and started to complain about everything.
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: