Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for making DAPI calls via dash sdk #1281

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: support for making DAPI calls via dash sdk #1281

merged 2 commits into from
Apr 23, 2024

Conversation

HashEngineering
Copy link
Collaborator

@HashEngineering HashEngineering commented Apr 19, 2024 •
edited
Loading

Issue being fixed or feature implemented

Related PR's and Dependencies

dashpay/kotlin-platform#2

Others:

  1. feat: support android builds rs-x11-hash#6
  2. fix: support android bls-signatures#88
  3. fix: add tls-webpki-roots to support tls on mobile (Android, iOS) platform#1828

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@HashEngineering HashEngineering self-assigned this Apr 19, 2024
@HashEngineering HashEngineering marked this pull request as ready for review April 23, 2024 13:20
Syn-McJ
Syn-McJ approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HashEngineering
Copy link
Collaborator Author

This will be merged into a new dashpay-sdk branch

@HashEngineering HashEngineering changed the base branch from dashpay to dashpay-sdk April 23, 2024 21:44
@HashEngineering HashEngineering merged commit 23cbcc3 into dashpay-sdk Apr 23, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the dashpay-fetch-identities branch April 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syn-McJ Syn-McJ Syn-McJ approved these changes

Assignees

@HashEngineering HashEngineering

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HashEngineering @Syn-McJ