Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coinbase): upgrade to payment methods v3 #1273

Merged
merged 6 commits into from
Mar 25, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Mar 22, 2024

payment-methods v2 is being shut down.

Issue being fixed or feature implemented

  • Upgraded to payment_methods v3.
  • Related changes.
  • Disabled auth limits check since auth_limits is null
  • Removed unneeded Build.VERSION_CODES.N checks

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • [] I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Mar 22, 2024
Comment on lines 56 to 60
fun getDeviceLocale(): Locale {
val countryCode = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
val countryCode = if (!isRunningUnitTest) {
LocaleList.getDefault()[0].country
} else {
Locale.getDefault().country
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we don't need the Build.VERSION_CODES.N check anymore, the unit test fails on LocaleList.getDefault()[0], and mocking the static method doesn't seem to work. This workaround is somewhat ugly, but will do for now.

@HashEngineering HashEngineering merged commit 158566d into master Mar 25, 2024
2 checks passed
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HashEngineering HashEngineering deleted the chore-coinbase-payment-methods branch September 9, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants