chore(coinbase): upgrade to payment methods v3 #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syn-McJ
commented
Mar 25, 2024
Comment on lines
56
to
60
| fun getDeviceLocale(): Locale { | ||
| val countryCode = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { | ||
| val countryCode = if (!isRunningUnitTest) { | ||
| LocaleList.getDefault()[0].country | ||
| } else { | ||
| Locale.getDefault().country |
There was a problem hiding this comment.
While we don't need the Build.VERSION_CODES.N check anymore, the unit test fails on LocaleList.getDefault()[0], and mocking the static method doesn't seem to work. This workaround is somewhat ugly, but will do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
payment-methods v2 is being shut down.
Issue being fixed or feature implemented
auth_limitsis nullBuild.VERSION_CODES.NchecksRelated PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: