Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improvements for the publish pipeline #1194

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Aug 26, 2023

Issue being fixed or feature implemented

  • The language list in prepare_changelog is amended to reflect our top 7
  • Fetch the current version_code to avoid failure during metadata update

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)
  • During the last release

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Aug 26, 2023
supply(
track: 'internal',
track_promote_to: "production",
rollout: rollout
rollout: rollout,
version_code: version_code
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading metadata between publish and promote requires specifying the version_code. We could parse it from the .gradle file, but this is easier.

Some tabs/spaces inconsistencies in this file which we can ignore for now.

Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be merged after 9.0.6 is pushed.

@HashEngineering HashEngineering merged commit 4972838 into master Sep 8, 2023
2 checks passed
@HashEngineering HashEngineering deleted the chore-fastlane-improvements branch September 26, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants