Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashpay): username request details #1176

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jul 28, 2023

When the user clicks on a username request, the request details screen should be presented.

Issue being fixed or feature implemented

  • Request details screen UI
  • Some fixes

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Jul 28, 2023
Comment on lines -92 to -99
if (sortedList.isNotEmpty()) {
val max = when (filterState.sortByOption) {
UsernameSortOption.VotesDescending -> sortedList.first().votes
UsernameSortOption.VotesAscending -> sortedList.last().votes
else -> sortedList.maxOf { it.votes }
}
sortedList.forEach { it.hasMaximumVotes = it.votes == max }
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed since the blue badge is for usernames you voted for, not the usernames with maximum votes.

Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HashEngineering HashEngineering merged commit 4698b51 into dashpay Jul 30, 2023
2 checks passed
@Syn-McJ Syn-McJ deleted the dashpay-voting-details branch August 1, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants