fix: render the platform private/public key (base64) correctly #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashEngineering
commented
Jul 9, 2023
| @@ -309,7 +309,7 @@ class MasternodeKeysViewModel @Inject constructor( | |||
| val bytes = ByteArray(64) | |||
| decryptedKey.privKeyBytes.copyInto(bytes, 0, 0, 32) | |||
| // public key bytes have a 0x00 prefix byte that is ignored | |||
| decryptedKey.pubKey.copyInto(bytes, 32, 1, 32) | |||
| decryptedKey.pubKey.copyInto(bytes, 32, 1, 33) | |||
There was a problem hiding this comment.
pubKey is 33 bytes. In this format, we need the last 32 bytes copied. The parameters for copyInto are indexes, rather than lengths.
* The last byte was always set to zero (0x00)
HashEngineering
force-pushed
the
bugfix-hpmn-keys
branch
from
8c8ddd4
to
f490649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Fix the HPMN Operator private / public keypair rendering in base64 format.
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist: