Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bump pybind version to 2.13.6 #97

Merged
merged 1 commit into from
Oct 8, 2024
Merged

refactor: bump pybind version to 2.13.6 #97

merged 1 commit into from
Oct 8, 2024

Conversation

PastaPastaPasta
Copy link
Member

For some reason, building, only inside of dash core, on asahi linux (aarch64 16k page size running on m1 mac pro) failing with errors like:

-- pybind11 v2.10.0 
CMake Error at build/_deps/pybind11-src/tools/pybind11NewTools.cmake:189 (python3_add_library):
  Unknown CMake command "python3_add_library".
Call Stack (most recent call first):
  src/dashbls/python-bindings/CMakeLists.txt:16 (pybind11_add_module)

when I bump to 2.13.6 it solves this. Really not sure why

@UdjinM6
Copy link

UdjinM6 commented Oct 8, 2024

could probably backport Chia-Network#432 instead

@PastaPastaPasta
Copy link
Member Author

Do we care to backport stuff?

UdjinM6
UdjinM6 approved these changes Oct 8, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do sometimes https://github.com/dashpay/bls-signatures/pulls?q=is%3Apr+is%3Aclosed+backport

but I have no strong preference for this PR, just an option, so

utACK e835ece

kwvg
kwvg approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e835ece

@PastaPastaPasta PastaPastaPasta merged commit ae40c5c into dashpay:develop Oct 8, 2024
22 of 27 checks passed
@PastaPastaPasta PastaPastaPasta deleted the refac/pybind-bump-2.13.6 branch October 8, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@kwvg kwvg kwvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PastaPastaPasta @UdjinM6 @kwvg