Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream #1

Open
wants to merge 151 commits into
base: main
Choose a base branch
from
Open

Sync with upstream #1

wants to merge 151 commits into from

Conversation

jojobyte
Copy link

This synchronizes our fork with the upstream version and should update the IIFE version to have the latest changes.

Breaking changes to be aware of:

  • No longer exist:
    • Secp256k1.utils._normalizePrivateKey
    • Secp256k1.utils._bigintTo32Bytes
    • Secp256k1.utils.mod
    • Secp256k1.Point.BASE.multiplyAndAddUnsafe
      • Updated to use:
        • Secp256k1.utils.normPrivateKeyToScalar
        • Secp256k1.etc.numberToBytesBE
        • Secp256k1.etc.mod
        • Secp256k1.ProjectivePoint.BASE.mulAddQUns
  • Now exports ProjectivePoint instead of Point, although I included both in our IIFE wrapper.

@jojobyte jojobyte added the enhancement New feature or request label Jul 24, 2024
@jojobyte jojobyte requested a review from coolaj86 July 24, 2024 07:33
@jojobyte jojobyte linked an issue Jul 24, 2024 that may be closed by this pull request
@coolaj86
Copy link
Member

Since this is a major version change and major breaking change, and it's tracking a different repo, I think it makes more sense to save the current main as v1 and overwrite main with this v2 direct from the source repo, with a single commit overlaying the changes.

I think I can do that...

@jojobyte
Copy link
Author

@coolaj86 That is more or less what this is doing just with tweaks to package.json & github workflow scripts.

@coolaj86
Copy link
Member

@jojobyte Do we still need to maintain a fork with the new version? Or will it work without our modifications now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet UI - 3rd Party Integration: CrowdNode.js Updates
7 participants