test: use patching instead of permanently overwriting names of other modules #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used construct is problematic:
doap_set.create_doap_from_admin_route_response = Mock()
permanently overwrites that name in the other module. This can cause subsequent tests to fail unexpectedly, which is difficult to debug.Instead, https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch should be used to patch names of other modules temporarily.