Bug fix in cast to float with range checks

das-developers · Oct 22, 2024 · d0f3311 · d0f3311
1 parent 13482fa
commit d0f3311
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/das2/codec.c b/das2/codec.c
@@ -1065,24 +1065,25 @@ static DasErrCode _swap_write(DasBuf* pBuf, const ubyte* pSrc, size_t uVals, int
 	return DAS_OKAY;
 }
 
-/* Encode helper: change widths with checks ******************************** */
+/* Encode helper: change widths with checks and swap *********************** */
 
-static DasErrCode _cast_write(
+static DasErrCode _cast_swap_write(
 	DasBuf* pBuf, const ubyte* pSrc, size_t uVals, das_val_type vtAry, 
 	const ubyte* pFillIn, das_val_type vtBuf, const ubyte* pFillOut
 ){
 
 	uint64_t outval;
 	uint64_t outswap;
 
+	size_t   insize = das_vt_size(vtAry);
 	size_t   outsize = das_vt_size(vtBuf);
 	assert(outsize <= 8);
 
 	ubyte* pIn = NULL;
 	ubyte* pOut = NULL;
 
 	int nRet;
-	for(size_t u = 0; u < (uVals); u += outsize){
+	for(size_t u = 0; u < (uVals*insize); u += insize){
 
 		nRet = das_value_binXform(
 			vtAry, pSrc + u,          pFillIn,
@@ -1106,18 +1107,20 @@ static DasErrCode _cast_write(
 	return DAS_OKAY;
 }
 
-/* Encode helper: change widths with checks and swap *********************** */
+/* Encode helper: change widths with checks ******************************** */
 
-static DasErrCode _cast_swap_write(
+static DasErrCode _cast_write(
 	DasBuf* pBuf, const ubyte* pSrc, size_t uVals, das_val_type vtAry, 
 	const ubyte* pFillIn, das_val_type vtBuf, const ubyte* pFillOut
 ){
 
 	uint64_t outval;
+	size_t   insize  = das_vt_size(vtAry);
 	size_t   outsize = das_vt_size(vtBuf);
+	assert(outsize <= 8);
 
 	int nRet;
-	for(size_t u = 0; u < (uVals); u += outsize){
+	for(size_t u = 0; u < (uVals*insize); u += insize){
 
 		nRet = das_value_binXform(
 			vtAry, pSrc + u,          pFillIn,