Allow globs in workspace definitions #4223
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4127
Initially we thought we would not allow globs, because resolving them would be on the hot path of
ensureResolutionUpToDate
and thusdart run
.But I think we are getting close to the conclusion that the fast path of
ensureResolutionUpToDate
only should depend on.dart_tool/package_config.json
, not parsing and resolving pubspec.yamls - thus we can allow globs.There is still the issue that
executableForCommand
needs to know if a package is a direct dependency or not. We might want to solve that issue before landing this. Discussing in #4222