Fix exception when a parameter has no name (issue 30226)

[email protected] Review-Url: https://codereview.chromium.org//2986703002 .
dart-lang · Jul 21, 2017 · ced90f3 · ced90f3
1 parent 341172a
commit ced90f3
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/lib/src/rules/non_constant_identifier_names.dart b/lib/src/rules/non_constant_identifier_names.dart
@@ -54,10 +54,17 @@ class Visitor extends SimpleAstVisitor {
     }
   }
 
+  @override
+  visitConstructorDeclaration(ConstructorDeclaration node) {
+    if (node.name != null) {
+      checkIdentifier(node.name);
+    }
+  }
+
   @override
   visitFormalParameterList(FormalParameterList node) {
     node.parameters.forEach((FormalParameter p) {
-      if (p is! FieldFormalParameter) {
+      if (p is! FieldFormalParameter && p.identifier != null) {
         checkIdentifier(p.identifier, underscoresOk: true);
       }
     });
@@ -83,11 +90,4 @@ class Visitor extends SimpleAstVisitor {
       }
     });
   }
-
-  @override
-  visitConstructorDeclaration(ConstructorDeclaration node) {
-    if (node.name != null) {
-      checkIdentifier(node.name);
-    }
-  }
 }