Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEMP] Add verbose logging and only run format test #3094

Closed
wants to merge 2 commits into from

Conversation

DanTup
Copy link

@DanTup DanTup commented Nov 18, 2024

This is not for landing, only for running bots to try to debug #3092

@DanTup DanTup marked this pull request as ready for review November 18, 2024 13:55
@DanTup DanTup marked this pull request as draft November 18, 2024 13:55
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/default_dart.dart
pkgs/samples/lib/default_flutter.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart
pkgs/samples/tool/samples.dart

@DanTup
Copy link
Author

DanTup commented Nov 18, 2024

Seems like nothing failed, so I've removed the solo in case the issue might be triggered by having run earlier tests (seems like they may share a server and attempt to reset the overlays). Might just be flaky though 🤷‍♂️

@DanTup
Copy link
Author

DanTup commented Nov 18, 2024

@devoncarew assuming you approved the bots before, you may have to do again for the change above to remove solo. Thanks!

@DanTup
Copy link
Author

DanTup commented Nov 18, 2024

This does look like a server bug... See notes at #3092 (comment)

@DanTup
Copy link
Author

DanTup commented Nov 18, 2024

Thanks! Closing this because I have a local repro in the SDK (dart-lang/sdk#57120).

@DanTup DanTup closed this Nov 18, 2024
@devoncarew
Copy link
Member

Thanks for running this down!

@DanTup DanTup deleted the debug-format-issue branch November 18, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants