Skip to content

Commit

Permalink
Address early review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
simolus3 committed Jul 25, 2024
1 parent 4cee75f commit 4f6cacd
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions build_web_compilers/lib/src/dart2wasm_bootstrap.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:convert';
import 'dart:io';

Expand Down Expand Up @@ -65,6 +69,8 @@ https://github.com/dart-lang/build/blob/master/docs/faq.md#how-can-i-resolve-ski

args = [
'--packages=$multiRootScheme:///.dart_tool/package_config.json',
// The -E prefix is removed by dartdev when starting the actual dart2wasm
// process.
'-E--multi-root-scheme=$multiRootScheme',
'-E--multi-root=${scratchSpace.tempDir.uri.toFilePath()}',
for (var experiment in enabledExperiments)
Expand Down
8 changes: 4 additions & 4 deletions build_web_compilers/lib/src/platforms.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'package:build_modules/build_modules.dart';

/// `dart:` SDK libraries available in every platform supported by
/// build_webc_compilers.
/// build_web_compilers.
const _coreLibraries = [
'_internal',
'async',
Expand Down Expand Up @@ -39,11 +39,11 @@ const _additionalWasmLibraries = [
'ffi',
];

const _libraries = [..._coreLibraries, ..._additionalWebLibraries];
const _jsCompilerLibraries = [..._coreLibraries, ..._additionalWebLibraries];

final ddcPlatform = DartPlatform.register('ddc', _libraries);
final ddcPlatform = DartPlatform.register('ddc', _jsCompilerLibraries);

final dart2jsPlatform = DartPlatform.register('dart2js', _libraries);
final dart2jsPlatform = DartPlatform.register('dart2js', _jsCompilerLibraries);

final dart2wasmPlatform = DartPlatform.register(
'dart2wasm', [..._coreLibraries, ..._additionalWasmLibraries]);

0 comments on commit 4f6cacd

Please sign in to comment.