BUG: fix darshan-runtime config parsing leading to infinite loops #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various Darshan config variables take a CSV of regexes as input (e.g. APP_EXCLUDE, NAME_EXCLUDE). Darshan's code for iterating and parsing these regexes can cause an infinite loop if one of the regexes is unable to be compiled. E.g.,
The 2nd field is the regex CSV (in this case just a single regex), but
*is not a valid regex (it is a special character indicating that the preceding character(s) are repeated one or more times, but there are no preceding characters above) and causes an error when compiling the regex. This input causes Darshan to continuously output the following warning:This PR fixes the bug causing the Darshan library to continuously parse the same erroneous token rather than printing a warning once and advancing.