Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI, BENCH: pin seaborn to avoid namespace issues with asv #974

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

shanedsnyder
Copy link
Contributor

Temporary workaround for issue mentioned by @tylerjereddy in #972.

Copy link
Collaborator

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see why it is still failing, we use a flag for asv check in CI that leverages the "existing" Python interpreter/environment for all deps instead of using an isolated venv (to save on CI time).

So, I suppose we may want to additionally do this here:

--- a/.github/workflows/main_ci.yml
+++ b/.github/workflows/main_ci.yml
@@ -92,6 +92,7 @@ jobs:
           export LD_LIBRARY_PATH=$PWD/darshan_install/lib
           export DYLD_FALLBACK_LIBRARY_PATH=$PWD/darshan_install/lib
           cd darshan-util/pydarshan/benchmarks
+          python -m pip install "seaborn==0.13.0"
           python -m asv check -E existing
       - name: codecov check
         uses: codecov/codecov-action@v3

@github-actions github-actions bot added the CI continuous integration label Jan 25, 2024
@shanedsnyder
Copy link
Contributor Author

Thanks, I made a small tweak to your suggested changes to get things working on Python 3.7, where seaborn-13 is apparently not available. Looks like things are passing now across the board.

@tylerjereddy tylerjereddy merged commit 6dad628 into main Jan 25, 2024
20 checks passed
@tylerjereddy tylerjereddy deleted the snyder/pydarshan-ci-pin-seaborn branch January 25, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration performance pydarshan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants