Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring rating sample workflow explanation up to date #682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HobbyProgrammer
Copy link

In the import & review section, it says that by default, Darktable rates imported images with a one-star rating, and that pressing 0 gives images a zero-star rating. I just started using Darktable. After importing images, I found that they are marked as Not rated, and that there is no zero star rating. I guess this part of the manual is outdated. Here is my attempt on bringing it up to date.

@HobbyProgrammer HobbyProgrammer changed the title Fix rating sample workflow explanation Bring rating sample workflow explanation up to date Oct 3, 2024
@elstoc
Copy link
Contributor

elstoc commented Oct 3, 2024

I'd like to prove that change of behaviour myself and understand whether it was changed on purpose or was a bug/regression introduced unintentionally. Do you know when that behaviour changed? It would be good to find the darktable PR that changed it

@HobbyProgrammer
Copy link
Author

Okay, I dug deeper into what is happening for me, now. It seems that my camera puts Rating 0 into the EXIF data of all images by default. The default settings for import are ignore EXIF rating = false and initial rating = 1. The description on ignore EXIF rating says if not set and EXIF rating is found, it overrides 'inital rating'. This explains why I was observing a different behavior than what is explained in the manual. With this, the error is on my end, and we can close the PR, or if you think it is worth it, mention this parameter in the import tab to avoid confusion for future readers.
Personally, I was also slightly confused with the zero-star rating term, since the UI is showing Not rated, but I think that is a very minor detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants