Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gtk warnings from #17425 #17571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dterrahe
Copy link
Member

When reordering a lib by dragging it, a dropzone is shown above or below the module currently hovered over. If the module contains widgets that also accept drags, like entries, textviews, and some treeviews, those widgets try to process the hover and sometimes don't correctly indicate that they don't accept the module type and that the parent widget should process the hover. In that case, the hoverzone gets hidden when it shouldn't. This can lead to flickering, especially when passing over the 6 text widgets in the metadata editor. #17425 "fixed" this by removing the marking of the textviews as a drop target. But when the textview gets destroyed when dt is closed, the associated textbuffer is updated one last time, leading to a redefinition of the accepted drop target types, which was now invalid because the widget is no longer a drop zone. This PR reinstates the flickering to get rid of the error message on close, since there doesn't seem to be another workaround. Fixes #17476

Also checks first if a module is "visible" (i.e. not completely removed using new functionality in #17425, rather than just collapsed) before trying to realize a widget via a shortcut. Shortcuts to removed modules will still not work. Fixes #17530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant