Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change way to interact with filmstrip #17568

Merged
merged 5 commits into from
Oct 3, 2024
Merged

change way to interact with filmstrip #17568

merged 5 commits into from
Oct 3, 2024

Conversation

TurboGit
Copy link
Member

@TurboGit TurboGit commented Sep 30, 2024 •
edited
Loading

This has bothered me since the first implementation of the filmstrip in darktable.

Use the same way for selection as in the Lighttable.

  • Click : select a single image
  • Ctrl+Click : toggle image selection
  • Shift+Click : select range

And so now to change image in darkroom a double click is needed.

@TurboGit TurboGit added priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions default-behavior-change labels Sep 30, 2024
@TurboGit TurboGit added this to the 5.0 milestone Sep 30, 2024
@TurboGit TurboGit added the documentation-pending a documentation work is required label Sep 30, 2024
@zisoft
Copy link
Collaborator

zisoft commented Sep 30, 2024

This is exactly what was discussed in #16275 👍

@AlicVB
Copy link
Contributor

AlicVB commented Sep 30, 2024

Great ! I agree that this is way better.
But iirc, when the big thumbtable rework has happened, some have raise an issue about double-click not really possible in some situations (touchpad ??)
Maybe we can ensure a way to switch to another image with something else ? (click + 'd' or 'enter')

@ralfbrown
Copy link
Collaborator

With this PR, double-clicking to edit a different image resets the selection to be just that image. Current master preserves the selection when switching images by clicking on the filmstrip. As I've mentioned elsewhere, switching to GtkGesture should allow completely independent actions for single- and double-click, rather than having the double-click first perform the single-click action. But that's a much bigger code change.

(Also typo in your post: Shift-Click to select range - Alt-Click does nothing but could perhaps be repurposed to switch image being edited without resetting the selection.)

@TurboGit
Copy link
Member Author

With this PR, double-clicking to edit a different image resets the selection to be just that image.

Indeed, will fix that.

@TurboGit
Copy link
Member Author

But iirc, when the big thumbtable rework has happened, some have raise an issue about double-click not really possible in some situations (touchpad ??)

Don't remember but to me clearly we can have double click on a touchpad... So maybe something else, we'll see.

@TurboGit TurboGit force-pushed the po/filmstrip-sel branch 2 times, most recently from 7748ada to 6c19bde Compare October 1, 2024 16:13
@TurboGit
Copy link
Member Author

TurboGit commented Oct 1, 2024

With this PR, double-clicking to edit a different image resets the selection to be just that image.

This is now fixed, was not easy, but should be ok.

If you read this please test as some tricky parts have been reworked.

ralfbrown
ralfbrown reviewed Oct 1, 2024
View reviewed changes
src/dtgtk/thumbtable.c Outdated Show resolved Hide resolved
@TurboGit TurboGit force-pushed the po/filmstrip-sel branch 2 times, most recently from cd6a67a to 3529472 Compare October 1, 2024 20:00
@TurboGit TurboGit changed the title RFC: change way to interact with filmstrip change way to interact with filmstrip Oct 2, 2024
@TurboGit TurboGit added release notes: pending feature: redesign current features to rewrite labels Oct 2, 2024
@TurboGit
Minor code reformatting.
d6cd5f1
@TurboGit
Use dt_is_valid_imgid(id).
9977c26
@TurboGit
Change filmstrip UX to match what lighttable does.
cc07d2b 
So for the selection:

- Click        : select a single image
- Ctrl+Click   : toggle image selection
- Shift+Click  : select range

And so now to change image in darkroom:

- Double-click : change edited image

Note that the tricky part is that a double-click does raise:

   GDK_BUTTON_PRESS
   GDK_BUTTON_PRESS
   GDK_2BUTTON_PRESS

So we do resort on a timeout action for single click (GDK_BUTTON_PRESS)
selection which gets remove if a double click is actually done.

Part of #16275.
@TurboGit
Do not use hard-coded doubl-click-time, request it from settings.
187a743
@TurboGit
Simplify select single call (no need for a list).
74e9c90 
And make sure the single selection occurs after the edited image
to fix the range selection.
@TurboGit
Copy link
Member Author

TurboGit commented Oct 3, 2024

After more testing and fixing this is ready to me. Let's merge for field testing.

@TurboGit TurboGit merged commit 2274c2a into master Oct 3, 2024
7 checks passed
@TurboGit TurboGit deleted the po/filmstrip-sel branch October 3, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfbrown ralfbrown ralfbrown left review comments

Assignees
No one assigned
Labels
default-behavior-change documentation-pending a documentation work is required feature: redesign current features to rewrite priority: low core features work as expected, only secondary/optional features don't scope: UI user interface and interactions
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TurboGit @zisoft @AlicVB @ralfbrown