Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

po/splash screen #17552

Closed
wants to merge 20 commits into from
Closed

po/splash screen #17552

wants to merge 20 commits into from

Conversation

TurboGit
Copy link
Member

@ralfbrown : See last commit to use SVG for logo.

ralfbrown and others added 19 commits September 28, 2024 08:54
Give the user feedback on the startup process as early as possible so
that they aren't left wondering whether darktable is actually starting
successfully (opening a large library can take multiple seconds even
on SSD, and crawling a large collection for updated sidecar could
potentially take over a minute).

Also add pref to disable the splash screen.
This allows the splash screen to be properly styled from the
beginning, so that it does not change color/font in the middle of
startup.
This lets the darktable GUI display before the potentially very lengthy crawl,
and affords the future opportunity to add code to cancel the crawl or at least
display the directory names as they are crawled.

Some other adjustments to avoid a UI hang when doing the crawl after
LUA initialization fires up the script installer.
The sidecar crawler now updates with percentage completed once per second.
The crawling had to be moved back before LUA startup to avoid hanging the UI.
this permits GUI initialization to proceed without showing an empty
main window with a default geometry before we know the actual
configured geometry (which may even be on a different display).
Unfortunately, on some systems minimizing or hiding the main window
during initialization results in the main window remaining hidden or
iconified.  We'll have to live with a brief display of an empty window....
@TurboGit
Copy link
Member Author

Again feel free to cherry-pick.

@TurboGit TurboGit added this to the 5.0 milestone Sep 28, 2024
@jenshannoschwalm
Copy link
Collaborator

Just tested this the first time, very nice.

One minor thing, i would expect the logo to be centered on the main window. Would that be possible/desired?

@ralfbrown
Copy link
Collaborator

The splashscreen window is centered on the screen, while the darktable main window is sized/positioned as it was at last shutdown. I had made some attempts to keep the main window hidden until all the initializations were complete, but while both attempts worked on my machine, each had problems on someone else's. My third attempt in my most recent commit on the PR is to size the main window so that the splashscreen hides it until the splashscreen is closed, then resize the finished main window to the stored geometry. That makes it look like it pops open just as the splashscreen vanishes.

@TurboGit
Copy link
Member Author

Closing as commits now cherry-picked into #17202

@TurboGit TurboGit closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants