Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighttable default overlay text and darkroom information line improvements #17511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastibe
Copy link
Contributor

@bastibe bastibe commented Sep 22, 2024

The default lighttable extended overlay texts and darkroom information lines show only the basic exposure parameters and file name, but there is typically room for some more text. This pull request adds some more information and formats the information that is there a bit more nicely.

In particular, it adds information about the camera and lens used, and uses a bold font for the exposure parameters. It also adds a unit to the shutter speed, to make it more easily distinguishable from the other values. And it removes the center dot between the exposure parameters to save space. Thanks to the bold font, there is enough structure to the text to remain legible.

Original Improved
Screenshot 2024-09-22 at 10 35 49 Screenshot 2024-09-22 at 10 22 49
Screenshot 2024-09-22 at 10 26 54 Screenshot 2024-09-22 at 10 22 59

(no idea why the left thumbnail is smaller than the right. The images are the same size.)

Add additional detail to the default lighttable overlay text, and the darkroom information line.

Also make these labels easier to read by highlighting the exposure parameters in a bold font.
@bastibe
Copy link
Contributor Author

bastibe commented Sep 22, 2024

To try these new defaults, here they are in plain text:

Lighttable pattern for the thumbnail extended overlay text:

$(EXIF.MODEL) $(EXIF.LENS)$(NL)$(FILE_NAME).$(FILE_EXTENSION) • <b>$(EXIF_EXPOSURE)</b>s f/<b>$(EXIF_APERTURE)</b> <b>$(EXIF_FOCAL_LENGTH)</b>mm ISO<b>$(EXIF_ISO)</b> $(SIDECAR_TXT)

Darkroom pattern for the image information line:

$(EXIF.MAKER) <b>$(EXIF.MODEL) $(EXIF.LENS)</b> • $(FILE_NAME).$(FILE_EXTENSION) • <b>$(EXIF_EXPOSURE)</b>s <b>$(EXIF_FOCAL_LENGTH)</b>mm f/<b>$(EXIF_APERTURE)</b> ISO<b>$(EXIF_ISO)</b>

@wpferguson
Copy link
Member

I prefer the image on the left. IMO the image is what is important and I only look at the info if I need to. However, if it's configurable then I have no objection as long as it doesn't overwrite my current setting.

@Donatzsky
Copy link

Donatzsky commented Sep 24, 2024

I like the bold numbers, but the other changes very quickly break things if the filename or lens string are even just slightly longer than in the example.

2024-09-22t14-42-32_1461.cr2
Sigma 35mm f/1.4 DG HSM *OR* Sigma 35mm f/1.5 FF High-Speed Prime | 017

image image

As should be obvious, that's not very usable.

I do already have the extra camera and lens information in the darkroom, however, since I find it can be useful at times:
image
But, if we also put the filename in there, it too risks breaking:
image

@bastibe
Copy link
Contributor Author

bastibe commented Sep 25, 2024

Interesting discussion!

It seems that some values, such as lens and file names, are dangerous as a default value, as they are liable to be too long.

Perhaps these things should better be left as customization options then.

Feel free to close this, or continue discussing it. I'd be happy to change the defaults in this PR to something else if we find a consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants