Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bump to XCode 16 #17509

Closed
wants to merge 2 commits into from
Closed

CI: bump to XCode 16 #17509

wants to merge 2 commits into from

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Sep 21, 2024

No description provided.

@kmilos kmilos added the scope: macos support macos related issues and PR label Sep 21, 2024
@zisoft
Copy link
Collaborator

zisoft commented Sep 22, 2024

Please don't raise the deployment target. We want to support the oldest OS version with the newest Xcode version.

@@ -281,7 +281,7 @@ jobs:
matrix:
build:
- { os: macos-13, xcode: 15.2, deployment: 13.5 } # LLVM16, x86_64
- { os: macos-14, xcode: 15.4, deployment: 14.0 } # LLVM16, arm64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployment should be left at 14.0

@@ -385,7 +385,7 @@ jobs:

The Windows package requires Windows with UCRT (Universal C Runtime), which is shipped with Windows 10+. Darktable should also work on Windows 8.1 [on condition that you install this runtime yourself](https://support.microsoft.com/en-us/topic/update-for-universal-c-runtime-in-windows-c0514201-7fe6-95a3-b0a5-287930f3560c).

The macOS `*-x86_64.dmg` package requires at least macOS 13.5 (Ventura), the `*-arm64.dmg` package requires at least macOS 14.0 (Sonoma).
The macOS `*-x86_64.dmg` package requires at least macOS 13.5 (Ventura), the `*-arm64.dmg` package requires at least macOS 14.5 (Sonoma).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

@kmilos
Copy link
Contributor Author

kmilos commented Sep 22, 2024

Please don't raise the deployment target.

Ah, I thought that was the heuristic once the new OS version comes out, i.e. 15 just now...

Sure, I'll put it back once I get a chance.

@MStraeten
Copy link
Collaborator

be careful with xcode16 - highway as a dependency for some darktable dependencies won’t build due to a clang issue …
see google/highway#2317

@kmilos
Copy link
Contributor Author

kmilos commented Sep 26, 2024

@zisoft Shall I close this one and let you handle the macOS matrix as you see fit given that macos-15 runners are now available as well?

@zisoft
Copy link
Collaborator

zisoft commented Sep 26, 2024

For now we have no pressure to bump the Xcode version.
We will drop support for macOS 13 with the winter release 2025 when macOS 16 will be released.

@kmilos kmilos closed this Sep 26, 2024
@kmilos kmilos deleted the patch-1 branch September 26, 2024 08:10
@kmilos
Copy link
Contributor Author

kmilos commented Sep 30, 2024

@zisoft
Copy link
Collaborator

zisoft commented Sep 30, 2024

Thanks!
So for the nightly builds and my release builds we will stay on the macos-14 runner with Xcode 15 to ensure the deployment target of macOS 14.

For the CI we can use the next macos-15 runner with Xcode 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: macos support macos related issues and PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants