-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R5 Mark II noiseprofile #17347
base: master
Are you sure you want to change the base?
Add R5 Mark II noiseprofile #17347
Conversation
We |
sure, wanted to submit the PR to have it "off the list" :) |
@kmilos why is there a dependency on libraw for noise profiles? The noise profile is also useful for (converted) DNG files and a new libraw release may take ~2 years. |
We ideally want to have base support implemented first, if not for the model string normalisation: "Canon EOS R5m2" to "EOS R5 Mark II". Without it, the automatic profile lookup won't work, and it'll be available to choose manually only (which is of course an option should people prefer to have it before LibRaw makes it public). |
The quasi-support of the camera through Adobe DNG Converter is also not ideal, but it is better than not being able to work with images in darktable. Therefore, I see this option as desirable. This will improve the user experience (ok, not in an ideal way) for those who want to work with these images without waiting for libraw support. |
People who don't want to wait for libraw can follow my findings here and compile R5m2 support themselves https://discuss.pixls.us/t/how-to-add-camera-support-to-libraw-darktable/44774 finetuned wbpresets can't be created yet, because the script does not create any output. Guess it needs exiftool to support the tags. |
Done like the one for the R5, works well on my samples but maybe @rawfiner wants to take a look at it. The x2 rule for the second a value doesn't seem to be given. The script was not complaining though.
noise_result.pdf