po/colorpicker edit - edit area & point #17051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
added
bugfix
|
Yes, indeed a step into a better workflow. One usability downside, you have to prior-select the picker with the correct "mode" (either click for point or right-click for area) and thus have to know the live samples mode. Could we instead activate the main picker in the correct way via right-click on the live sample? |
Sure, that's what I commented in my first post :) |
|
Ahh, didn't get that. So show me the way to the next ... :-) |
|
No time for 4.8.1 and actually not a fix so moving this for 5.0. |
we need to select it select the shape in it ctrl+click over an area and when this is done the picker MUST be active change size / position click back on the picker (= deselect it) the area should properly be recorded.
TurboGit
force-pushed
the
po/colorpicker-edit
branch
from
deb3371
to
7e0c2e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for editing area & point as hinted by the tooltip.
@jenshannoschwalm : This is based on top of your PR but it independent, can you test?
How it works:
I'd like to avoid 1 and as soon as we right click we enter in edit mode and maybe right-click again to update the sample. Seems a better user interaction to me, what do you think?