Removing max height of histogram #17045
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also limited. This is not desirable, though, since screens with high
resolution make the histogram small and hard to read, particularly when
using the scope. This commit fixes this by doing two things:
1) Making functions auto-detect whether they should use height or
aspect ratio to manage the container size by checking whether
the passed "config_str" variable refers to height or aspect ratio
-- Note: this is actually safer anyway, since it was perfectly
possible before to pass an AR request to a height function
2) Changing the histogram back to using aspect ratio instead of height
|
Limited height histogram/waveform is actually some kind of regression as it seems there were no such limitation in past releases. A tall waveform is better for distinction of tones. |
|
Is there anything else needed from me for this to get added? Would it be useful for me (or would it be useful in the future) to open a ticket to track/document the issue better? |
|
This pull request has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please verify it has no conflicts with the master branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing height limits on modules, the histogram container was also limited. This is not desirable, though, since screens with high resolution make the histogram small and hard to read, particularly when using the scope. This commit fixes this by doing two things:
Making functions auto-detect whether they should use height or
aspect ratio to manage the container size by checking whether
the passed "config_str" variable refers to height or aspect ratio
-- Note: this is actually safer anyway, since it was perfectly
possible before to pass an AR request to a height function
Changing the histogram back to using aspect ratio instead of height