-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications for Ruby 3.1. #27
Open
zerebubuth
wants to merge
1
commit into
dark-panda:master
Choose a base branch
from
zerebubuth:ruby-3.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs the 'matrix' gem which is now external to the Ruby Standard Library. Changed finalizer to pass in the @Frames array so that the target of each is explicit.
@dark-panda Is there anything that we can do to help move this PR along? It would be great to avoid all these warnings on ruby 3.1 and beyond. |
@dark-panda : could you please look into this issue? Currently, we're experiencing pages and pages of warning messages in our unit tests as well as running instances, and it's really distracting for everyone. Thanks a lot!
|
tomhughes
added a commit
to tomhughes/openstreetmap-website
that referenced
this pull request
Aug 14, 2024
tomhughes
added a commit
to tomhughes/openstreetmap-website
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was getting some warnings when running the test suite from https://github.com/openstreetmap/openstreetmap-website saying things like:
I'm not entirely sure why the finalizer is behaving differently now, but changing it to a proc capturing
@frames
instead of on@frames
itself seemed to work for me, and is recommended in the Ruby 3.1 docs.Also, Ruby 3.1 removed the "matrix" library from the standard lib, so it now needs to be required as a gem. Thanks @gravitystorm for showing me the right way to do that! I tested on 2.7 as well, and it looked like depending on "matrix" was OK there too.