Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for pre-built aarch64 #328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chayim
Copy link

@chayim chayim commented Apr 9, 2024

Thank you so much for this project!

I went to pip install on a baremetal aarch64 box, and found that I required cmake in order to install. As such, I wanted to contribute this PR, which if accepted would pre-build aarch64 wheels accordingly.

There are two changes here, both to the workflow:

  1. The default cibuildwheel on Linux only builds for amd64. Adding aarch64 to the CIBW_ARCHS_LINUX flag, will enable arm builds, assuming qemu is installed. I used this in a past project here, in case you wanted to see something else using it.
  2. As a result, we need to install qemu. That too, is installed using the qemu-action

I'm hoping this might be accepted, so that aarch64 builds start to appear in a future release. Thanks again!

@chayim
Copy link
Author

chayim commented May 2, 2024

@daquexian Is there something else I can do to help here?

@chayim
Copy link
Author

chayim commented Aug 14, 2024

@daquexian ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant