-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for cryptography api #719
Conversation
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Thank you very much for the PR Kent, I'll try to get to it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR. Thanks @KentHsu
Can you run tox -e flake8
and tox -e ruff
please?
The linter is failing at the moment.
That step runs tox -e flake8
, tox -e type
, tox -e mypy
and tox -e ruff
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR @KentHsu, thank you! I have just a few nits.
This PR should address the linter failing: #725 |
@KentHsu we are beyond code freeze - are you able to address the comments from @elena-kolevska by end of next week? Otherwise, this is unfortunately going to miss the 1.14 release of the SDK. |
Currently seeing type check failures as well. I recommend running the above mentioned commands to resolve type check, lint, autoformatting etc |
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Hi @berndverst, @elena-kolevska, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 86.37% 86.59% +0.22%
==========================================
Files 79 84 +5
Lines 4094 4467 +373
==========================================
+ Hits 3536 3868 +332
- Misses 558 599 +41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work @KentHsu.
I'm approving the PR so as not to block the release, but to make this contribution 100% complete we would need a little example in the docs (this file) so that developers can discover and use your work.
It would be great if you could send a new PR with that addition.
Thanks again for your contribution, the community appreciates it!
Description
Implement below in Dapr gRPC client
Implement below in Dapr gRPC aio client
Add cryptography examples follow go-sdk crypto example
Issue reference
Please reference the issue this PR will close: #548
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: