-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Added Crypto #492
Conversation
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: sadath-12 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 35 35
Lines 2841 2841
=======================================
Hits 1991 1991
Misses 738 738
Partials 112 112 ☔ View full report in Codecov by Sentry. |
I'm all for adding validation flows to the sdk. Just not sure about committing relatively large binaries from the quickstarts to the repo. |
Use a markdown file with little words is enough, we can comment it ( the file type and size we support etc.) in the doc |
which large binaries? |
its just one |
This needs to be added to the validation workflow to have any effect on CI. |
* Examples: Added Crypto Signed-off-by: sadath-12 <[email protected]> * docs: update Signed-off-by: sadath-12 <[email protected]> --------- Signed-off-by: sadath-12 <[email protected]>
Description
Taking direct reference from
https://github.com/dapr/quickstarts/tree/master/cryptography/go/sdk
The reason to add it here is to make sure our linter detects if any buggy changes happening to crypto code
Issue reference
Please reference the issue this PR will close: #395
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: