Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Added Crypto #492

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Examples: Added Crypto #492

merged 2 commits into from
Jan 19, 2024

Conversation

sadath-12
Copy link
Contributor

@sadath-12 sadath-12 commented Jan 3, 2024

Description

Taking direct reference from https://github.com/dapr/quickstarts/tree/master/cryptography/go/sdk

The reason to add it here is to make sure our linter detects if any buggy changes happening to crypto code

Issue reference

Please reference the issue this PR will close: #395

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: sadath-12 <[email protected]>
@sadath-12 sadath-12 requested a review from a team as a code owner January 3, 2024 06:55
Signed-off-by: sadath-12 <[email protected]>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04f7b59) 70.08% compared to head (c215be9) 70.08%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files          35       35           
  Lines        2841     2841           
=======================================
  Hits         1991     1991           
  Misses        738      738           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee
Copy link
Member

mikeee commented Jan 7, 2024

I'm all for adding validation flows to the sdk. Just not sure about committing relatively large binaries from the quickstarts to the repo.

@daixiang0
Copy link
Member

Use a markdown file with little words is enough, we can comment it ( the file type and size we support etc.) in the doc

@sadath-12
Copy link
Contributor Author

I'm all for adding validation flows to the sdk. Just not sure about committing relatively large binaries from the quickstarts to the repo.

which large binaries?

@sadath-12
Copy link
Contributor Author

sadath-12 commented Jan 11, 2024

its just one main.go which would also help us to validate in our ci easily also I had the same thought which you commented . but if we have a look carefully there are many other examples directly taken from examples repo including pubsub (only few things are changed but overall its same) so I had to make a choice of consistency here

@yaron2 yaron2 merged commit d655a2c into dapr:main Jan 19, 2024
7 checks passed
@mikeee
Copy link
Member

mikeee commented Jan 19, 2024

This needs to be added to the validation workflow to have any effect on CI.
I'll get a PR raised

mikeee pushed a commit to mikeee/dapr_go-sdk that referenced this pull request Jan 19, 2024
* Examples: Added Crypto

Signed-off-by: sadath-12 <[email protected]>

* docs: update

Signed-off-by: sadath-12 <[email protected]>

---------

Signed-off-by: sadath-12 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Add cryptography api examples
4 participants