Removes floating classes and introduces Dapr.Common project #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <[email protected]>
…e shared floating classes Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…udit capability Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
philliphoff
approved these changes
Oct 16, 2024
humandigital-michiel
pushed a commit
to humandigital-agency/dapr-dotnet-sdk
that referenced
this pull request
Oct 23, 2024
Extracting classes out to common project --------- Signed-off-by: Whit Waldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a number of classes that have been floating around in "src/Shared" and referenced by the various packages. Another PR #1363 seeks to use a type available in a NuGet package in an update to one of these types necessitating they be in a project now.
It also pulls
DaprExceptionfrom theDapr.Clientproject and makes it available more commonly for still other PRs (#1331)Doing this here so as to make the impact of the PR in #1331 significantly smaller and opens the door to future smaller PRs (e.g. removing the dependency on
ArgumentVerifierthroughout in favor of the null argument exception API that's built-in).This should not introduce a breaking change as I updated the namespace for each type to use
Dapras they originally were assigned to. It's just a referential change in each .csproj from a floating file to a referenced project.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: None
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: