Sftp Binding Component Docs #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Arslan <[email protected]>
3 tasks
hhunter-ms
approved these changes
Nov 4, 2024
msfussell
reviewed
Nov 4, 2024
There was a problem hiding this comment.
@arslanmusta Looks great. Thanks for creating this. Generally keeping acronym to caps at the start of the doc with a full name description of the binding (similar to SMTP binding)
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
…indings/sftp.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
…indings/sftp.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
…indings/sftp.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
…indings/sftp.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
…indings/sftp.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
|
Stale PR, paging all reviewers |
hhunter-ms
requested changes
Nov 14, 2024
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/sftp.md
Outdated
Show resolved
Hide resolved
|
Stale PR, paging all reviewers |
Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Mustafa Arslan <[email protected]>
|
@holopin-bot @arslanmusta Thank you! |
|
Congratulations @arslanmusta, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm4875cla05780clhd6a4f3j2 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Adding Sftp Binding component documentation.
Issue reference
Related PR: dapr/components-contrib#3505