Update documentation to reflect changes in dapr/dapr#8228 #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevgen Polyak <[email protected]>
7 tasks
passuied
reviewed
Oct 24, 2024
| | not supported | `--image` | | `dapr.io/sidecar-image` | Dapr sidecar image. Default is daprio/daprd:latest. The Dapr sidecar uses this image instead of the latest default image. Use this when building your own custom image of Dapr and or [using an alternative stable Dapr image]({{< ref "support-release-policy.md#build-variations" >}}) | | ||
| | `--internal-grpc-port` | not supported | | not supported | gRPC port for the Dapr Internal API to listen on | | ||
| | `--internal-grpc-port` | not supported | | `dapr.io/internal-grpc-port` | gRPC port for the Dapr Internal API to listen on (default `50002`) | |
There was a problem hiding this comment.
There should be a mention that if overriden, all services in the cluster should use the same internal gRPC port to guarantee service to service communication
passuied
reviewed
Oct 24, 2024
| | `--dapr-http-port` | `--dapr-http-port` | | not supported | The HTTP port for the Dapr API | | ||
| | `--dapr-http-max-request-size` | --dapr-http-max-request-size | | `dapr.io/http-max-request-size` | Increasing max size of request body http and grpc servers parameter in MB to handle uploading of big files. Default is `4` MB | | ||
| | `--dapr-http-read-buffer-size` | --dapr-http-read-buffer-size | | `dapr.io/http-read-buffer-size` | Increasing max size of http header read buffer in KB to handle when sending multi-KB headers. The default 4 KB. When sending bigger than default 4KB http headers, you should set this to a larger value, for example 16 (for 16KB) | | ||
| | `--dapr-grpc-port` | `--dapr-grpc-port` | | `dapr.io/grpc-port` | gRPC port for the Dapr API to listen on (default `50001`) | |
There was a problem hiding this comment.
There should be a mention that if overriden, all services in the cluster should use the same gRPC port to guarantee service to service communication
passuied
reviewed
Oct 24, 2024
| | `--dapr-grpc-port` | `--dapr-grpc-port` | | `dapr.io/grpc-port` | gRPC port for the Dapr API to listen on (default `50001`) | | ||
| | `--dapr-http-port` | `--dapr-http-port` | | not supported | HTTP port for the Dapr API to listen on (default `3500`) | | ||
| | `--dapr-http-max-request-size` | `--dapr-http-max-request-size` | | `dapr.io/http-max-request-size` | Increasing max size of request body http and grpc servers parameter in MB to handle uploading of big files. Default is `4` MB | | ||
| | `--dapr-http-read-buffer-size` | `--dapr-http-read-buffer-size` | | `dapr.io/http-read-buffer-size` | Increasing max size of http header read buffer in KB to handle when sending multi-KB headers. The default 4 KB. When sending bigger than default 4KB http headers, you should set this to a larger value, for example 16 (for 16KB) | |
There was a problem hiding this comment.
While we're at it should we update to the new read-buffer-size and max-body-size parameters and corresponding annotation that now replace http-read-buffer-size and http-max-request-size ?
There was a problem hiding this comment.
I don't mind, but I suspect it would not be approved as it's out of scope
There was a problem hiding this comment.
thanks for including this change!
Signed-off-by: Yevgen Polyak <[email protected]>
Signed-off-by: Yevgen Polyak <[email protected]>
passuied
reviewed
Oct 25, 2024
| | `--dapr-http-read-buffer-size` | --dapr-http-read-buffer-size | | `dapr.io/http-read-buffer-size` | Increasing max size of http header read buffer in KB to handle when sending multi-KB headers. The default 4 KB. When sending bigger than default 4KB http headers, you should set this to a larger value, for example 16 (for 16KB) | | ||
| | `--dapr-grpc-port` | `--dapr-grpc-port` | | `dapr.io/grpc-port` | Sets the Dapr API gRPC port (default `50001`); all cluster services must use the same port for communication | | ||
| | `--dapr-http-port` | `--dapr-http-port` | | not supported | HTTP port for the Dapr API to listen on (default `3500`) | | ||
| | `--dapr-http-max-request-size` | `--dapr-http-max-request-size` | | `dapr.io/http-max-request-size` | Increasing max size of request body http and grpc servers parameter in MB to handle uploading of big files. Default is `4` MB | |
There was a problem hiding this comment.
This setting is also deprecated in favor of max-body-size
Signed-off-by: Yevgen Polyak <[email protected]>
passuied
approved these changes
Oct 25, 2024
hhunter-ms
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
The change to docs reflects the changes introduced in dapr/dapr#8228
Issue reference
#4400