Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for limiting workflow concurrency in .NET fan-in/out example #3986

Closed
wants to merge 303 commits into from
Closed

Added example for limiting workflow concurrency in .NET fan-in/out example #3986

wants to merge 303 commits into from

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

I love rich documentation. It's so satisfying to read something that details a new concept, shares examples and really sets me up to succeed. But I don't like it when said documentation introduces another idea and leaves me to my own devices to figure out how to do it.

Tonight I was reading about the different workflow patterns. In the fan-out/fan-in pattern, it explains how a series of parallel tasks can be completed at once, but then it leaves a note at the end: "While not shown in the example, it's possible to go further and limit the degree of concurrency using simple, language-specific constructs."

As it took me a minute to figure out a worthwhile .NET approach to doing this, I wanted to contribute it back so future me isn't left hanging. I leave it to others to figure out other language equivalents.

Issue reference

None - saw this in the docs and after determining a solution, wanted to contribute it back.

hhunter-ms and others added 27 commits January 11, 2024 17:34
@hhunter-ms
Merge pull request #3910 from JoshVanL/preview-feature-component-hot-…
cc3d110 
…reloading

Component Hot Reloading
@elena-kolevska @msfussell
Apply suggestions from code review
3a676db 
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
@passuied @hhunter-ms @msfussell
Feature/add-kafka-pubsub-schema-registry (#3946)
ae4e137 
* Added doc for kafka pubsub Avro schema registry support

Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

* Update setup-apache-kafka.md

Signed-off-by: Patrick Assuied <[email protected]>

* Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-apache-kafka.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>

---------

Signed-off-by: Patrick Assuied <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
@passuied
fix formatting (#3950)
b0dafe0 
Signed-off-by: Patrick Assuied <[email protected]>
@msfussell
Merge branch 'v1.13' into error-codes
de0f222
@elena-kolevska
Apply suggestions from code review
d71bd4b 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Small fixes after review
e16d22f 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Small update
63858ae 
Signed-off-by: Elena Kolevska <[email protected]>
@hhunter-ms
update howtos and patterns
11ab77a 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
add link to js sdk
cb78f17 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'issue_3869' of https://github.com/hhunter-ms/docs into …
cbe1276 
…issue_3869
@hhunter-ms
Merge branch 'v1.13' into issue_3869
216679b
@hhunter-ms
fix localized link
fd58074 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'issue_3869' of https://github.com/hhunter-ms/docs into …
b66db73 
…issue_3869
@elena-kolevska
Add related links
29fc98b 
Signed-off-by: Elena Kolevska <[email protected]>
@hhunter-ms
Merge pull request #3908 from elena-kolevska/error-codes
e344601 
Error codes
@hhunter-ms
tweak for limitations
5027a74 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'v1.13' into issue_3868
c2b7342
@hhunter-ms
upmerge
0fcbd0a 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge pull request #3976 from hhunter-ms/upmerge_01-26c
72e139d 
Upmerge 1.12 --> 1.13
@hhunter-ms
prep 1.13 for release
9ab5a8b 
Signed-off-by: Hannah Hunter <[email protected]>
@kaibocai
Update limitation for js
fab5b19 
Update limitation for js

Signed-off-by: kaibocai <[email protected]>
@kaibocai
Update workflow-features-concepts.md
da0fd19 
Signed-off-by: kaibocai <[email protected]>
@hhunter-ms
add monitor pattern
af916d6 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Merge branch 'v1.13' into issue_3869
89ca6dd
@WhitWaldo
Added example for limiting workflow concurrency in .NET
3407121 
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo
Added missing close tab markup and surrounding tabs
557e7b9 
Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo WhitWaldo requested review from a team as code owners January 30, 2024 08:17
tlund101 and others added 21 commits April 9, 2024 14:35
@tlund101
Update confusing examples for subscribePollInterval
18a6d63 
Most of the other options show an example identical to the default value.  This was an exception and could prove confusing when reading the docs

Signed-off-by: Trevor Lund <[email protected]>
@marcduiker
Merge branch 'v1.13' into update-sdk-feature-table
c3c58bf
@riosengineer
Update holopin.yml (#4108)
3b7e997 
Updated holopin.yaml file to use the default holopin badge for the docs repo.

Signed-off-by: Dan Rios <[email protected]>
@AnnuCode @marcduiker @msfussell
adding Dapr Repository Index for contributing (#4088)
58b1fb5 
* adding Dapr Repository Index for contributing

Signed-off-by: Annu Singh <[email protected]>

* adding cli repo

Signed-off-by: Annu Singh <[email protected]>

---------

Signed-off-by: Annu Singh <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
@msfussell
Merge branch 'v1.13' into patch-2
20fd7a9
@tlund101 @msfussell
Edit this page link directed to the wrong branch (#4101)
b94d959 
Signed-off-by: Trevor Lund <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
@hhunter-ms @msfussell
Add 1.13.1 and 1.13.2 to the docs (#4110)
bf7120e 
* update support docs for patch releases

Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/operations/support/support-release-policy.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>

* Update daprdocs/content/en/operations/support/support-release-policy.md

Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>

---------

Signed-off-by: Hannah Hunter <[email protected]>
Signed-off-by: Hannah Hunter <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
@marcduiker @msfussell
Add Diagrid conductor to integrations (#4112)
95179f9 
* Add Diagrid conductor to integrations

Signed-off-by: Marc Duiker <[email protected]>

* Add diagram

Signed-off-by: Marc Duiker <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Diagrid/diagrid-conductor.md

Signed-off-by: Mark Fussell <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Diagrid/diagrid-conductor.md

Signed-off-by: Mark Fussell <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Diagrid/diagrid-conductor.md

Signed-off-by: Mark Fussell <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Diagrid/diagrid-conductor.md

Signed-off-by: Mark Fussell <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Diagrid/diagrid-conductor.md

Signed-off-by: Mark Fussell <[email protected]>

* Update daprdocs/content/en/developing-applications/integrations/Diagrid/diagrid-conductor.md

Signed-off-by: Mark Fussell <[email protected]>

---------

Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Mark Fussell <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
@msfussell
Merge branch 'v1.13' into update-sdk-feature-table
0ef3ceb
@marcduiker @msfussell
Update daprdocs/content/en/developing-applications/sdks/_index.md
3e8db2f 
Co-authored-by: Mark Fussell <[email protected]>
Signed-off-by: Marc Duiker <[email protected]>
@marcduiker @msfussell
Add font usage for MacOS (#4094)
b951391 
Signed-off-by: Marc Duiker <[email protected]>
Co-authored-by: Mark Fussell <[email protected]>
@hhunter-ms
Merge branch 'v1.13' into patch-2
70781fb
@hhunter-ms
Merge branch 'v1.13' into update-sdk-feature-table
d76f728
@hhunter-ms
Merge pull request #4102 from tlund101/patch-2
b80bde3 
Update confusing examples for subscribePollInterval
@msfussell
Merge branch 'v1.13' into update-sdk-feature-table
b09ef71
@hhunter-ms
Merge pull request #4095 from marcduiker/update-sdk-feature-table
c75daf0 
Update table with sdk features
@hhunter-ms
Merge branch 'v1.13' into issue_4081
8f59430
@hhunter-ms
Merge pull request #4083 from hhunter-ms/issue_4081
78cd66a 
Fix the copy/paste typo
@hhunter-ms
Merge branch 'v1.13' into issue_4063
766478c
@hhunter-ms
Merge pull request #4084 from hhunter-ms/issue_4063
a107511 
Add section on graceful shutdown duration
@james-bartlett
Clarify that disabling kubernetes built in secret store can only be d…
0bfa02b 
…one with an annotation, not by setting a helm argument (#4124)

Clarify that disabling kubernetes built in secret store can only be done with an annotation, not by setting a helm argument

Signed-off-by: james-bartlett <[email protected]>
@hhunter-ms
Copy link
Collaborator

@WhitWaldo friendly bump

@WhitWaldo
Copy link
Contributor Author

@hhunter-ms Updated the docs to reflect the example given in the SO post to include support for retaining a returned value for each of the tasks

@hhunter-ms
Copy link
Collaborator

@WhitWaldo it looks like 1.13 was pulled into this PR, which is pointing into 1.12 - do you mind either reopening as a new PR, or somehow reverting the 1.13 merge?

@WhitWaldo WhitWaldo closed this May 7, 2024
@WhitWaldo WhitWaldo mentioned this pull request May 7, 2024
Merged
7 tasks
@WhitWaldo WhitWaldo deleted the limit-workflow-concurrency-dotnet branch May 7, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum requested changes

@halspang halspang Awaiting requested review from halspang

Assignees

@WhitWaldo WhitWaldo

Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.