Add -f - example for dapr run
#3872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
msfussell
reviewed
Nov 20, 2023
| @@ -36,7 +36,7 @@ dapr run [flags] [command] | |||
| | `--dapr-http-port`, `-H` | `DAPR_HTTP_PORT` | `3500` | The HTTP port for Dapr to listen on | | |||
| | `--enable-profiling` | | `false` | Enable "pprof" profiling via an HTTP endpoint | | |||
| | `--help`, `-h` | | | Print the help message | | |||
| | `--run-file`, `-f` | | Linux/MacOS: `$HOME/.dapr/dapr.yaml` | Run multiple applications at once using a Multi-App Run template file. Currently in [alpha]({{< ref "support-preview-features.md" >}}) and only available in Linux/MacOS | | |||
| | `--run-file`, `-f` | | Linux/MacOS: `$HOME/.dapr/dapr.yaml` | Run multiple applications at once using a Multi-App Run template file. Currently in [alpha]({{< ref "support-preview-features.md" >}}) and only available in Linux/MacOS. Pass `-` as the value to read template from stdin. | | |||
There was a problem hiding this comment.
Suggested change
| | `--run-file`, `-f` | | Linux/MacOS: `$HOME/.dapr/dapr.yaml` | Run multiple applications at once using a Multi-App Run template file. Currently in [alpha]({{< ref "support-preview-features.md" >}}) and only available in Linux/MacOS. Pass `-` as the value to read template from stdin. | | |
| | `--run-file`, `-f` | | Linux/MacOS: `$HOME/.dapr/dapr.yaml` | Run multiple applications at once using a Multi-App Run template file. Currently in [alpha]({{< ref "support-preview-features.md" >}}) and only available in Linux/MacOS. | |
| Pass `-` as the value to read template from stdin. | |
There was a problem hiding this comment.
I would add an example here to be explicit. Having an example then makes it clear.
There was a problem hiding this comment.
@stuartleeks - Did you see my comment above ^^
There was a problem hiding this comment.
@msfussell - I've updated to include an example of the full command syntax inline in the table. Is that what you were meaning?
|
Stale PR, paging all reviewers |
|
@msfussell - yes, I saw the comment and hope to add an example this week 😄 |
stuartleeks
force-pushed
the
patch-2
branch
2 times, most recently
from
6119f93 to
36400ef
Compare
Signed-off-by: Stuart Leeks <[email protected]>
Signed-off-by: Stuart Leeks <[email protected]>
|
Stale PR, paging all reviewers |
|
@msfussell - since the code change for this has been merged, can you let me know whether the additional changes I made in this PR address your feedback? It would be good to get the docs updated :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Docs update related to dapr/cli#1364
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Update
dapr rundocs related to reading run file from stdin (dapr/cli#1364)Issue reference