Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3851 #3852

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fixes #3851 #3852

merged 2 commits into from
Nov 8, 2023

Conversation

jorimvanhove
Copy link

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Updated translation/docs-zh submodule pointer to https://github.com/dapr/docs-zh/tree/v1.6_content

Issue reference

#3851

@jorimvanhove jorimvanhove requested review from a team as code owners October 27, 2023 04:24
@yaron2 yaron2 added this to the 1.13 milestone Oct 27, 2023
@jorimvanhove
Copy link
Author

I will try to resolve the failed checks before reopening.

@jorimvanhove jorimvanhove reopened this Nov 2, 2023
@jorimvanhove jorimvanhove force-pushed the bugfix/#3851 branch 3 times, most recently from 26cf292 to a259bab Compare November 3, 2023 17:55
msfussell
msfussell approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hhunter-ms hhunter-ms merged commit 8adc507 into dapr:v1.12 Nov 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhunter-ms hhunter-ms hhunter-ms approved these changes

@msfussell msfussell msfussell approved these changes

Assignees

@jorimvanhove jorimvanhove

Labels
None yet
Projects
None yet
Milestone
1.13
Development

Successfully merging this pull request may close these issues.
5 participants
@jorimvanhove @msfussell @hhunter-ms @yaron2 @JorimVanHoveGS