Create 'quorum' queues in RabbitMQ #3699
Conversation
Signed-off-by: Álvaro Aguilar <[email protected]>
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-rabbitmq.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
|
changes applied. thanks @hhunter-ms ! |
|
Stale PR, paging all reviewers |
|
@aaguilartablada - The |
The PR #3193 is bad documentation, as my PR dapr/components-contrib#2816 only allows classic and quorum queues. It does not include support for stream. I think my documentation is OK as queue type is indicated at subscription level, not at component level. |
Signed-off-by: Hannah Hunter <[email protected]>
|
resolved conflicts |
|
@aaguilartablada - Look at my comment here https://github.com/dapr/docs/pull/3193/files#r1326422581 |
|
@msfussell let me insist, please. My PR dapr/components-contrib#2816 does not include metadata for RabbitMQ pubsub component. It includes metadata for subscription the same way subscription contains metadata for routing key without including it in component. The comment you just mentioned is to document a pull request that was closed without merging. You can go to the issue associated dapr/components-contrib#2544 and then you will see that the PR dapr/components-contrib#2556 is closed. This PR tried to add metadata to pubsub component, right. But my solution, that was already merged, has another approach: configuring the queue type through subscription. |
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rabbitmq.md
Outdated
Show resolved
Hide resolved
…ubsub/setup-rabbitmq.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Álvaro Aguilar-Tablada Espinosa <[email protected]>
|
Stale PR, paging all reviewers |
It closes issue #3685