Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Workflow docs for Java SDK #3662

Merged
merged 27 commits into from
Sep 25, 2023
Merged

[docs] Workflow docs for Java SDK #3662

merged 27 commits into from
Sep 25, 2023

Conversation

hhunter-ms
Copy link
Collaborator

@hhunter-ms hhunter-ms commented Aug 2, 2023 •
edited
Loading

@hhunter-ms
scaffold out docs for workflow java sdk
0211dfe 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
add java tabs
3fdf6d5 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms self-assigned this Aug 2, 2023
@hhunter-ms hhunter-ms requested review from a team as code owners August 2, 2023 20:24
@hhunter-ms hhunter-ms added this to the 1.12 milestone Aug 2, 2023
@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Aug 2, 2023
RyanLettieri
RyanLettieri suggested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@RyanLettieri RyanLettieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass through, just a few minor comments here and there

daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md Outdated Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-manage-workflow.md Show resolved Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-manage-workflow.md Outdated Show resolved Hide resolved
@hhunter-ms hhunter-ms mentioned this pull request Sep 14, 2023
Closed
6 tasks
@hhunter-ms
update examples in how tos
52ed2b6 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
add workflow patterns
d3618b2 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms removed the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Sep 20, 2023
@hhunter-ms
nyemade limitation edit
ae71e14 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
address all but one todo
37e78d7 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
dummy link for workflow package
bac5957 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
add java to quickstart
e3af25c 
Signed-off-by: Hannah Hunter <[email protected]>
nyemade-uversky
nyemade-uversky reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@nyemade-uversky nyemade-uversky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only have one change related to the limitations and everything else looks good

@hhunter-ms
fix localized link
cd472f1 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
removing some typos
b06d0f2 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms changed the title [docs][WIP] Workflow docs for Java SDK [docs] Workflow docs for Java SDK Sep 21, 2023
@hhunter-ms
add ryan review
6b14399 
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms
Copy link
Collaborator Author

@macromania please take a look!

@msfussell msfussell added the P0 label Sep 22, 2023
macromania
macromania approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@macromania macromania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhunter-ms LGTM, great work 😀

msfussell
msfussell approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hhunter-ms hhunter-ms merged commit 4d57fbe into dapr:v1.12 Sep 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanLettieri RyanLettieri RyanLettieri requested changes

@nyemade-uversky nyemade-uversky nyemade-uversky requested changes

@msfussell msfussell msfussell approved these changes

@macromania macromania macromania approved these changes

Assignees

@hhunter-ms hhunter-ms

Labels
P0
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.
5 participants
@hhunter-ms @macromania @msfussell @nyemade-uversky @RyanLettieri