Kafka Pubsub fixes: Avro serialization caching and retries #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgen-el8
reviewed
Nov 22, 2024
yevgen-el8
reviewed
Nov 22, 2024
passuied
changed the title
…abled by default with a TTL of 5min Signed-off-by: Patrick Assuied <[email protected]>
…n some weird circumstances - To avoid complexity, always exiting the for loop in case the RetryNotify fails... - Let dapr re-initiate the session in those cases - Address PR feedback and fix breaking tests Signed-off-by: Patrick Assuied <[email protected]>
…ges in some weird circumstances Signed-off-by: Patrick Assuied <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>
passuied
force-pushed
the
feature/kafka-pubsub-avro-caching
branch
from
375876d
to
e6c2d4b
Compare
yevgen-el8
approved these changes
Nov 25, 2024
yaron2
reviewed
Nov 26, 2024
Signed-off-by: Patrick Assuied <[email protected]>
yaron2
approved these changes
Nov 26, 2024
passuied
added a commit
to passuied/components-contrib
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Patrick Assuied <[email protected]> Co-authored-by: Yaron Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
session.Context()Issue reference
#3609
#3529
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: