-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MODX3 support (dont break in MODX2) #39
Open
dimasites
wants to merge
26
commits into
danyaPostfactum:master
Choose a base branch
from
dimasites:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaceв missing in MODX3 variable for its hardcoded value
https://docs.modx.com/3.x/ru/extending-modx/menus/action-list reference to this changes |
Added fresh MODX-version screenshots
Перед изменениями (cherry picked from commit 1028e3fa5229bdf1514f42bfaa6151e4dc438304)
Правки установщика пакета Исправлена форма, JS-скрипты и CSS-стили (только для дефолтного скина monoo-lisa) Добавлен процессор поиска
(cherry picked from commit a6116f84a828435ceb7c9b672c35511cdf6cdc00)
Уменьшена их ширина чтобы длинные названия не выталгивали вкладки за пределы окна (cherry picked from commit 93b7e8f03dc579dd0a38e95cd3ce2a5b946b9087)
Удалил лишние строки в билдере
dimasites
force-pushed
the
master
branch
2 times, most recently
from
April 28, 2023 18:11
91271c2
to
fa20783
Compare
Add submodule "modx-build-environment-gui"
==================================== - Fix small (as expected) editor frame height in some cases via default autogrow plugin settings - Removed Flash plugin, because .swf format is outdated - Added html5video plugin. Now we can paste .mp4 videos via editor!
== - Old HTML elements replaced to actual by default in new (and only new) pasted or typed content. - • <strong> replaced to <b> tag (thanks @dimasites) - • <em> replaced to <i> tag - Improved MODX3 support: fixed search by pagetitle in "paste link" dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced missing in MODX3 variable for its hardcoded value.
My test screenshots with comments:
but this variable missed in MODX3